mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <>
Subject Re: Review Request 65898: Add `MesosContainerizerLaunchHelper` and subclasses for different OSes.
Date Mon, 05 Mar 2018 21:48:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated March 5, 2018, 9:48 p.m.)

Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James Peach, and
Zhitao Li.


Updated `CMakeLists.txt` to reflect the new source files.

Bugs: MESOS-8257

Repository: mesos


This patch is a refactor from `launch.cpp`, intended for porting and
splitting OS-specific launch logic (initially `installResourceLimits`,
`prepareMounts` and `chroot`) into different OS-based subclasses.
There is no change in business logic from the counterparts in

Diffs (updated)

  src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef 
  src/ a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/slave/containerizer/mesos/launch/helper.hpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/helper.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/linux_helper.hpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/linux_helper.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/posix_helper.hpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/posix_helper.cpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/windows_helper.hpp PRE-CREATION 
  src/slave/containerizer/mesos/launch/windows_helper.cpp PRE-CREATION 





Jason Lai

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message