mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Review Request 65891: Windows: Fixed bug with CPU isolator not checking the max boundary.
Date Fri, 02 Mar 2018 23:16:40 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Akash Gupta and Joseph Wu.

Repository: mesos


The `set_job_cpu_limit` function does not sanitize its input, e.g.
`cpus`, causing a bug when more CPUs were requested than exist on the

For instance, in Mesos it was not possible to start a single task
which consumed every CPU, because the executor overcommit would cause
the task to ask for 0.1 more CPUs than available. So on a quad-core
machine, it'd ask for 4 CPUs, but that would cause the limiter to set
a limit at 4.1 CPUs, which exceeds the maximum allowed, causing an
"Invalid parameter" error when setting the CPU limit. We can avoid
this by ensuring the `cpu_rate` value is in the range of [1, 10000],
regardless of the input.


  3rdparty/stout/include/stout/windows/os.hpp 545a0052c87652ec35adf12bb184fd35f1238977 



Tested manually and can successfully now deploy a 12 CPU task on a 12 core machine.

Will file an issue to add appropriate unit tests.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message