mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65876: Enabled `--fetch_stall_timeout` in curl-based URI fetcher plugins.
Date Fri, 02 Mar 2018 19:20:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65876/
-----------------------------------------------------------

(Updated March 2, 2018, 7:20 p.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Fixed a compilation error on Windows.


Bugs: MESOS-8620
    https://issues.apache.org/jira/browse/MESOS-8620


Repository: mesos


Description
-------

This patch passes the `--fetch_stall_timeout` agent flag into
`DockerFetcherPlugin` (through setting flag `docker_stall_timeout` in
the Docker store) and `CurlFetcherPlugin` (through setting flag
`curl_stall_timeout` in the Appc store).


Diffs (updated)
-----

  src/slave/containerizer/mesos/provisioner/appc/store.cpp c1f9661906eae019e43e1c3df7c28cccad3a6bb0

  src/slave/containerizer/mesos/provisioner/docker/store.cpp c308bb04773fa81265d91a1247b3db3434b5746b

  src/uri/fetchers/curl.hpp 909c2eb450630912c13831c3aa180fbccc8e9e4b 
  src/uri/fetchers/curl.cpp 43584aaa424dc57f00880d5c89cdb73f23685800 
  src/uri/fetchers/docker.hpp 6a89c0a69dd6f454cc22d025644900416e55ad50 
  src/uri/fetchers/docker.cpp 21f8eb15903d505ba1cabe1f77a8f5d7043964d5 


Diff: https://reviews.apache.org/r/65876/diff/2/

Changes: https://reviews.apache.org/r/65876/diff/1-2/


Testing
-------

sudo make check


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message