mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Peterson <benja...@python.org>
Subject Review Request 65886: Do not realpath executables from launcher_dir.
Date Fri, 02 Mar 2018 17:03:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65886/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Mesos realpaths some helper executables (e.g., mesos-executor) but not
others (mesos-executor and mesos-fetcher) before executing them. I
don't see any reason for the inconsistency here, and not doing it
saves some code.


Diffs
-----

  src/slave/containerizer/fetcher.cpp a49411b7bac2d5a50a75d0b802842c2f61fe58c6 
  src/slave/slave.cpp e2facb3c15a2f907f6497c58a36842ed707f2c70 


Diff: https://reviews.apache.org/r/65886/diff/1/


Testing
-------

`make check` passes.


Thanks,

Benjamin Peterson


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message