mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 65872: Windows: Fixed location of Docker's `config.json` file.
Date Fri, 02 Mar 2018 00:59:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65872/#review198496
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65872']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65872

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65872/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (131 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (1244 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (39 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (43 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (85 ms total)

[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2466 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2491 ms total)

[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2481 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2506 ms total)

[----------] Global test environment tear-down
[==========] 915 tests from 90 test cases ran. (485182 ms total)
[  PASSED  ] 914 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 211 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65872/logs/mesos-tests-stderr.log):

```
I0302 00:59:34.753571   112 master.cpp:10258] Updating the state of task 05035c88-5e1e-4af4-8965-51d807731202
of framework 94cf145a-4799-44b1-813a-5296c194619b-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
I0302 00:59:34.753571  7916 slave.cpp:3879] Shutting down framework 94cf145a-4799-44b1-813a-5296c194619b-0000
I0302 00:59:34.754567  7916 slave.cpp:6586] Shutting down executor '05035c88-5e1e-4af4-8965-51d807731202'
of framework 94cf145a-4799-44b1-813a-5296c194619b-0000 at executor(1)@10.3.1.5:54299
I0302 00:59:34.755568  7916 slave.cpp:922] Agent terminating
W0302 00:59:34.755568  7916 slave.cpp:3875] Ignoring shutdown framework 94cf145a-4799-44b1-813a-5296c194619b-0000
because it is terminating
I0302 00:59:34.756568   112 master.cpp:10357] Removing task 05035c88-5e1e-4af4-8965-51d807731202
with resources cpus(allocated: *):4; mem(allocated: *):2048; dI0302 00:59:34.039572  6872
exec.cpp:162] Version: 1.6.0
I0302 00:59:34.075577  3844 exec.cpp:236] Executor registered on agent 94cf145a-4799-44b1-813a-5296c194619b-S0
I0302 00:59:34.080571  8968 executor.cpp:176] Received SUBSCRIBED event
I0302 00:59:34.085582  8968 executor.cpp:180] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0302 00:59:34.085582  8968 executor.cpp:176] Received LAUNCH event
I0302 00:59:34.090574  8968 executor.cpp:648] Starting task 05035c88-5e1e-4af4-8965-51d807731202
I0302 00:59:34.171572  8968 executor.cpp:483] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
I0302 00:59:34.716565  8968 executor.cpp:661] Forked command at 7412
I0302 00:59:34.756568  7964 exec.cpp:445] Executor asked to shutdown
I0302 00:59:34.757567  8968 executor.cpp:176] Received SHUTDOWN event
I0302 00:59:34.757567  8968 executor.cpp:758] Shutting down
I0302 00:59:34.757567  8968 executor.cpp:868] Sending SIGTERM to process tree at pid 7isk(allocated:
*):1024; ports(allocated: *):[31000-32000] of framework 94cf145a-4799-44b1-813a-5296c194619b-0000
on agent 94cf145a-4799-44b1-813a-5296c194619b-S0 at slave(398)@10.3.1.5:54278 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 00:59:34.759573 10336 containerizer.cpp:2338] Destroying container ca3b3a86-6677-413c-993d-7dc72373c2f4
in RUNNING state
I0302 00:59:34.759573 10336 containerizer.cpp:2952] Transitioning the state of container ca3b3a86-6677-413c-993d-7dc72373c2f4
from RUNNING to DESTROYING
I0302 00:59:34.760567   112 master.cpp:1306] Agent 94cf145a-4799-44b1-813a-5296c194619b-S0
at slave(398)@10.3.1.5:54278 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
disconnected
I0302 00:59:34.760567   112 master.cpp:3276] Disconnecting agent 94cf145a-4799-44b1-813a-5296c194619b-S0
at slave(398)@10.3.1.5:54278 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 00:59:34.760567   112 master.cpp:3295] Deactivating agent 94cf145a-4799-44b1-813a-5296c194619b-S0
at slave(398)@10.3.1.5:54278 (build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0302 00:59:34.760567  6964 hierarchical.cpp:344] Removed framework 94cf145a-4799-44b1-813a-5296c194619b-0000
I0302 00:59:34.760567 10336 launcher.cpp:156] Asked to destroy container ca3b3a86-6677-413c-993d-7dc72373c2f4
I0302 00:59:34.761574  6964 hierarchical.cpp:766] Agent 94cf145a-4799-44b1-813a-5296c194619b-S0
deactivated
I0302 00:59:34.809581  6964 containerizer.cpp:2791] Container ca3b3a86-6677-413c-993d-7dc72373c2f4
has exited
I0302 00:59:34.840575  8540 master.cpp:1149] Master terminating
I0302 00:59:34.842571  7496 hierarchical.cpp:609] Removed agent 94cf145a-4799-44b1-813a-5296c194619b-S0
I0302 00:59:35.505909  6840 process.cpp:929] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On March 1, 2018, 11:57 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65872/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 11:57 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Jeff Coffler, and Joseph Wu.
> 
> 
> Bugs: MESOS-8619
>     https://issues.apache.org/jira/browse/MESOS-8619
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per MESOS-8619, Docker checks `$USERPROFILE/.docker/config.json`
> instead of `$HOME`. Mesos overrides this environment variable in order
> to point Docker to a `config.json` file in another location, so we
> have to fix the assumption we made about Docker.
> 
> We do not add this constant to stout, because it is not consistent
> across Windows applications. This particular logic is specific to the
> implementation of Docker. Other applications might check `$HOME` or
> `$HOMEPATH` on Windows.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 876dfffc2ee68e345ff336fefa6cf908c3d2a5c4 
> 
> 
> Diff: https://reviews.apache.org/r/65872/diff/1/
> 
> 
> Testing
> -------
> 
> Deployed a `docker.zip` consisting of `.docker/config.json` in "Linux-form" i.e. with
base64 encoded password (not `wincred`) using the following task:
> 
> ```
> {
>     "name": "fetcher-test",
>     "task_id": {"value" : "fetcher"},
>     "agent_id": {"value" : ""},
>     "resources": [
>         {
>             "name": "cpus",
>             "type": "SCALAR",
>             "scalar": {
>                 "value": 1
>             }
>         },
>         {
>             "name": "mem",
>             "type": "SCALAR",
>             "scalar": {
>                 "value": 512
>             }
>         }
>     ],
>     "command": {
>         "uris": [ {"value": "file://C:/Users/andschwa/docker.zip"} ],
>         "shell": false
>     },
>     "container": {
>         "type": "DOCKER",
>         "docker": {"image": "andschwa/nanoserver:1709"}
>     }
> }
> ```
> 
> The `andschwa/nanoserver:1709` is a _private_ repo, and `docker logout` was run (and
confirmed that the machine could not pull the image manually).
> 
> With this patch and the `docker.zip` URI, it was fetched, unzipped, and found by `docker
pull`, enabling it to successfully pull the private image.
> 
> ```
> > docker images
> REPOSITORY            TAG                 IMAGE ID            CREATED             SIZE
> andschwa/nanoserver   1709                816017814fa2        2 weeks ago         312MB
> ```
> 
> This is difficult to unit-test because it requires private credentials, an external private
docker repo, and global side effects of Docker images (i.e. you can't have it cached). But
I am, of course, open to ideas of how to programmatically test this.
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message