mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles.
Date Thu, 01 Mar 2018 22:50:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65346/
-----------------------------------------------------------

(Updated March 1, 2018, 10:50 p.m.)


Review request for mesos, Benjamin Mahler, Kapil Arya, Michael Park, Meng Zhu, and Till Toenshoff.


Changes
-------

Removed `data-valign="middle"` attribute.


Bugs: MESOS-8486
    https://issues.apache.org/jira/browse/MESOS-8486


Repository: mesos


Description
-------

There is no limit field yet thus the limit displayed is currently
the guarantee. We will access this field once it will be exposed.


Diffs (updated)
-----

  src/webui/master/static/css/mesos.css 3e3a3b13cfc4d63aea73d0a6572b22a2de94541e 
  src/webui/master/static/index.html 46cb2843c2221ccebb7d811c0045be2c124afec1 
  src/webui/master/static/js/app.js 8960f9d4421f7b96ba06deb623afafb06013b622 
  src/webui/master/static/roles.html 1c84ad33a554e078d854e25b4d5ca311c8507f91 


Diff: https://reviews.apache.org/r/65346/diff/5/

Changes: https://reviews.apache.org/r/65346/diff/4-5/


Testing
-------

New UI:
![New UI](https://i.imgur.com/8YFZnmH.png)
The group columns cannot be ordered as they have sub-columns, this is expected.


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message