mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65868: Added inspect retries to the docker containerizer in `update` method.
Date Thu, 01 Mar 2018 19:51:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65868/#review198466
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65786, 65787, 65751, 65750, 65683, 65713, 65759, 65868]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 1, 2018, 10:12 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65868/
> -----------------------------------------------------------
> 
> (Updated March 1, 2018, 10:12 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Greg Mann.
> 
> 
> Bugs: MESOS-8605
>     https://issues.apache.org/jira/browse/MESOS-8605
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes the bug when a terminal status update is never sent
> after termination of the docker executor, when the Docker daemon hangs
> for `inspect` command. A terminal status update is postponed until
> containerizer `update` completes that uses `inspect` command to get
> a PID of the docker container. To address the issue, we retry `inspect`
> in the loop.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 030fb05186f7f360010bb7e5b4948faac69771cc 
>   src/slave/containerizer/docker.cpp 1f4eeb4628517707ab866014fcda9d9b15053d1f 
> 
> 
> Diff: https://reviews.apache.org/r/65868/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message