mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Schlicht <...@mesosphere.io>
Subject Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.
Date Thu, 01 Mar 2018 14:07:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review198448
-----------------------------------------------------------


Fix it, then Ship it!




I'm seeing a display issue for `protobuf_utils.cpp` in RB UI. Checked that file in a diff
viewer after applying the patch to current `master`.


src/tests/api_tests.cpp
Line 229 (original), 229 (patched)
<https://reviews.apache.org/r/65833/#comment278589>

    As this represents a single disk resource, let's name it `resource` or `disk`. `disk`
is what's used in similar test in `master_tests.cpp`.


- Jan Schlicht


On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2018, 1:55 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Bugs: MESOS-8388
>     https://issues.apache.org/jira/browse/MESOS-8388
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Displayed resource provider resources in GET_AGENTS response.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472 
>   include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d 
>   src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e 
>   src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c 
> 
> 
> Diff: https://reviews.apache.org/r/65833/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message