mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65839: Windows: Removed stout W* signal macros in `windows.hpp`.
Date Thu, 01 Mar 2018 09:45:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65839/
-----------------------------------------------------------

(Updated March 1, 2018, 9:45 a.m.)


Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Changes
-------

split commit into three


Summary (updated)
-----------------

Windows: Removed stout W* signal macros in `windows.hpp`.


Repository: mesos


Description
-------

`windows.hpp` defined a few macros for the status value of `waitpid`
that were either unused in the code base or were only used in gtest.
These macros handled signal logic, so they were removed since they
aren't used on Windows.


Diffs (updated)
-----

  3rdparty/stout/include/stout/gtest.hpp ce6e4de6a9f69ea121ff0ca6048316d678c8c857 
  3rdparty/stout/include/stout/windows.hpp b35e6b94ba6709254450be9429b6f48f2d276689 


Diff: https://reviews.apache.org/r/65839/diff/2/

Changes: https://reviews.apache.org/r/65839/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message