From reviews-return-73922-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Feb 23 22:43:43 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D78E418A60 for ; Fri, 23 Feb 2018 22:43:43 +0000 (UTC) Received: (qmail 87499 invoked by uid 500); 23 Feb 2018 22:43:43 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 87463 invoked by uid 500); 23 Feb 2018 22:43:43 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 87447 invoked by uid 99); 23 Feb 2018 22:43:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 22:43:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A25BAC0115; Fri, 23 Feb 2018 22:43:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id lux2BdWxD1-L; Fri, 23 Feb 2018 22:43:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A16135F216; Fri, 23 Feb 2018 22:43:41 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 44198E00D6; Fri, 23 Feb 2018 22:43:41 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 1961FC4013A; Fri, 23 Feb 2018 22:43:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6468305626930761638==" MIME-Version: 1.0 Subject: Review Request 65780: Removed an unnecessary argument from master::Call validation. From: Benjamin Mahler To: Meng Zhu , Michael Park Cc: Benjamin Mahler , mesos Date: Fri, 23 Feb 2018 22:43:41 -0000 Message-ID: <20180223224341.12421.46835@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Mahler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65780/ X-Sender: Benjamin Mahler Reply-To: Benjamin Mahler X-ReviewRequest-Repository: mesos --===============6468305626930761638== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65780/ ----------------------------------------------------------- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos Description ------- The principal is not needed by the validation function. Diffs ----- src/master/http.cpp acf10a0f396234ec9f444c9b41515d657379d6ad src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp 9254cd22e67d9aca53135701575fb0857ff6f7d6 Diff: https://reviews.apache.org/r/65780/diff/1/ Testing ------- make check Thanks, Benjamin Mahler --===============6468305626930761638==--