From reviews-return-73876-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Feb 23 08:57:48 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5E0D318AD5 for ; Fri, 23 Feb 2018 08:57:48 +0000 (UTC) Received: (qmail 47714 invoked by uid 500); 23 Feb 2018 08:57:48 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 47684 invoked by uid 500); 23 Feb 2018 08:57:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 47668 invoked by uid 99); 23 Feb 2018 08:57:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Feb 2018 08:57:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F0DB6C0145; Fri, 23 Feb 2018 08:57:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id yCkO0cQuYhmA; Fri, 23 Feb 2018 08:57:45 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BE5B35F2C2; Fri, 23 Feb 2018 08:57:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D9C1E00D3; Fri, 23 Feb 2018 08:57:44 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 4E726C400F6; Fri, 23 Feb 2018 08:57:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7081965003347319368==" MIME-Version: 1.0 Subject: Re: Review Request 65759: Added inspect retries to the Docker executor. From: Greg Mann To: Greg Mann , Michael Park , Alexander Rukletsov , Gilbert Song Cc: Andrei Budnik , mesos Date: Fri, 23 Feb 2018 08:57:41 -0000 Message-ID: <20180223085741.12421.64801@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Greg Mann X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65759/ X-Sender: Greg Mann References: <20180222203205.16917.34238@reviews-vm2.apache.org> In-Reply-To: <20180222203205.16917.34238@reviews-vm2.apache.org> Reply-To: Greg Mann X-ReviewRequest-Repository: mesos --===============7081965003347319368== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198168 ----------------------------------------------------------- src/docker/executor.cpp Lines 25 (patched) Is this necessary? src/docker/executor.cpp Lines 220 (patched) s/docker/Docker/ s/retry/retry the/ src/docker/executor.cpp Lines 221 (patched) s/inspect_loop/inspectLoop/ src/docker/executor.cpp Lines 233-236 (patched) Suggestion: "We need to clean up the hanging Docker CLI process. Discarding the `inspect` future triggers a callback in the Docker library that kills the subprocess and transitions the future." - Greg Mann On Feb. 22, 2018, 8:32 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65759/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 8:32 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gilbert Song, Greg Mann, and Michael Park. > > > Bugs: MESOS-8574 > https://issues.apache.org/jira/browse/MESOS-8574 > > > Repository: mesos > > > Description > ------- > > This patch adds retries for `inspect` command to workaround docker > daemon hangs. We assume that the docker daemon can be temporarily > unresponsive. If it's unresponsive, then any started docker cli > command hangs. To address the issue, we retry `inspect` in the loop. > > > Diffs > ----- > > src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc > > > Diff: https://reviews.apache.org/r/65759/diff/1/ > > > Testing > ------- > > internal CI > > Manually, described in /r/65713 > > > Thanks, > > Andrei Budnik > > --===============7081965003347319368==--