From reviews-return-73848-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Feb 22 18:26:01 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E31BE1784F for ; Thu, 22 Feb 2018 18:26:01 +0000 (UTC) Received: (qmail 45463 invoked by uid 500); 22 Feb 2018 18:26:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 45429 invoked by uid 500); 22 Feb 2018 18:26:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 45413 invoked by uid 99); 22 Feb 2018 18:26:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Feb 2018 18:26:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9DD44C089B; Thu, 22 Feb 2018 18:26:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.69 X-Spam-Level: X-Spam-Status: No, score=0.69 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id PNjsYD5sbBVn; Thu, 22 Feb 2018 18:25:59 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id D63985F188; Thu, 22 Feb 2018 18:25:58 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 22718E00B8; Thu, 22 Feb 2018 18:25:58 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E5D50C4013C; Thu, 22 Feb 2018 18:25:56 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6581320494331145916==" MIME-Version: 1.0 Subject: Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration. From: Mesos Reviewbot To: Alexander Rukletsov Cc: Mesos Reviewbot , mesos , Benno Evers Date: Thu, 22 Feb 2018 18:25:55 -0000 Message-ID: <20180222182555.16917.55485@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65758/ X-Sender: Mesos Reviewbot References: <20180222162514.16917.38973@reviews-vm2.apache.org> In-Reply-To: <20180222162514.16917.38973@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot X-ReviewRequest-Repository: mesos --===============6581320494331145916== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65758/#review198132 ----------------------------------------------------------- Patch looks great! Reviews applied: [65758] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 22, 2018, 4:25 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65758/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2018, 4:25 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-8336 > https://issues.apache.org/jira/browse/MESOS-8336 > > > Repository: mesos > > > Description > ------- > > It could happen that an agent re-sends its `RegisterSlaveMessage` > and with the correct timing, the master would assume that it > comes from a new agent with the same pid and store its information > in the registry. See MESOS-8336. > > > Diffs > ----- > > src/tests/master_tests.cpp 3705fa7cc3c81a77dc431d5337a7d4a061fa84b9 > > > Diff: https://reviews.apache.org/r/65758/diff/1/ > > > Testing > ------- > > `./mesos-tests --gtest_filter="*AfterReconfiguration*" --gtest_repeat=1000 --gtest_throw_on_failure` > > > Thanks, > > Benno Evers > > --===============6581320494331145916==--