From reviews-return-73595-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Feb 21 10:41:30 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00AD11762A for ; Wed, 21 Feb 2018 10:41:30 +0000 (UTC) Received: (qmail 26981 invoked by uid 500); 21 Feb 2018 10:41:29 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 26947 invoked by uid 500); 21 Feb 2018 10:41:29 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26930 invoked by uid 99); 21 Feb 2018 10:41:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 10:41:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A1FBBC00DA; Wed, 21 Feb 2018 10:41:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id MDPXAIatZueZ; Wed, 21 Feb 2018 10:41:27 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 81EE55F1B3; Wed, 21 Feb 2018 10:41:27 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 18E41E00D6; Wed, 21 Feb 2018 10:41:27 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id E14BBC40137; Wed, 21 Feb 2018 10:41:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9206746056161096830==" MIME-Version: 1.0 Subject: Re: Review Request 63370: Added new --memory_profiling flag to agent and master binaries. From: Benno Evers To: Alexander Rukletsov Cc: mesos , Benjamin Mahler , Benno Evers Date: Wed, 21 Feb 2018 10:41:26 -0000 Message-ID: <20180221104126.28022.20086@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benno Evers X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63370/ X-Sender: Benno Evers References: <20171027190407.34917.33241@reviews-vm2.apache.org> In-Reply-To: <20171027190407.34917.33241@reviews-vm2.apache.org> Reply-To: Benno Evers X-ReviewRequest-Repository: mesos --===============9206746056161096830== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63370/ ----------------------------------------------------------- (Updated Feb. 21, 2018, 10:41 a.m.) Review request for mesos and Alexander Rukletsov. Repository: mesos Description ------- This flag allows explicit disabling of the memory profiler endpoint in the master and agent binaries. Diffs (updated) ----- src/master/flags.hpp 505786e5631c891a52d9d7db403eff312f461d3d src/master/flags.cpp 2f4aa697c2cb68cc3a23d42ef5f86cff95749b23 src/master/main.cpp 0040d65ec3a77c6d69ccc3a9065c6f1996c2a1f9 src/slave/flags.hpp 0c67bf214ceb93ae7ff088bec2648fa26ddac59e src/slave/flags.cpp 943aaaf58b5f36555f0902019b8c5c6522ab7afc src/slave/main.cpp 43292ead7ea22c2bd13ae63aee9a4364bf74f92c Diff: https://reviews.apache.org/r/63370/diff/3/ Changes: https://reviews.apache.org/r/63370/diff/2-3/ Testing ------- Thanks, Benno Evers --===============9206746056161096830==--