From reviews-return-73567-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Feb 20 19:43:20 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 92371179A9 for ; Tue, 20 Feb 2018 19:43:20 +0000 (UTC) Received: (qmail 61604 invoked by uid 500); 20 Feb 2018 19:43:20 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 61565 invoked by uid 500); 20 Feb 2018 19:43:20 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 61545 invoked by uid 99); 20 Feb 2018 19:43:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Feb 2018 19:43:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 488EDC0040; Tue, 20 Feb 2018 19:43:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.691 X-Spam-Level: X-Spam-Status: No, score=0.691 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id VLOXdZpeuHdO; Tue, 20 Feb 2018 19:43:17 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C39FA5F1F3; Tue, 20 Feb 2018 19:43:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 59190E0056; Tue, 20 Feb 2018 19:43:16 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 749E7C4015B; Tue, 20 Feb 2018 19:43:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5019995281243988005==" MIME-Version: 1.0 Subject: Re: Review Request 65624: Added fetcher tests for `stderr` output. From: Jeff Coffler To: Jie Yu , Akash Gupta , Joseph Wu , Jeff Coffler Cc: Andrew Schwartzmeyer , mesos Date: Tue, 20 Feb 2018 19:43:14 -0000 Message-ID: <20180220194314.2585.723@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jeff Coffler X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65624/ X-Sender: Jeff Coffler References: <20180220194021.2548.54451@reviews-vm2.apache.org> In-Reply-To: <20180220194021.2548.54451@reviews-vm2.apache.org> Reply-To: Jeff Coffler X-ReviewRequest-Repository: mesos --===============5019995281243988005== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/#review197799 ----------------------------------------------------------- src/tests/fetcher_tests.cpp Lines 132 (patched) These tests pretty much check the fetcher in a "stand-alone" environment. Could you add some tests to check within a container as well, particularly since fetcher logging is slightly different within a container? Note that while fetcher output is slightly different within a container, fetcher itself isn't (docker is sharing the same directory). But we don't have any sort of tests to validate that - that I'm aware of anyway. - Jeff Coffler On Feb. 20, 2018, 7:40 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65624/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2018, 7:40 p.m.) > > > Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The fetcher is supposed to log its `stderr` output to a redirected file > called `stderr` in the given sandbox directory. There previously existed > a bug on Windows due to incorrect handle inheritance where this > redirection failed silently, leaving the log empty. These unit tests > assert that the correct content is logged to the `stderr` file for both > a success and failure fetch scenario. > > > Diffs > ----- > > src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f > > > Diff: https://reviews.apache.org/r/65624/diff/1/ > > > Testing > ------- > > Windows (Linux pending): > ``` > [ RUN ] FetcherTest.LogSuccessToStderr > [ OK ] FetcherTest.LogSuccessToStderr (197 ms) > [ RUN ] FetcherTest.LogFailureToStderr > [ OK ] FetcherTest.LogFailureToStderr (320 ms) > ``` > > > Thanks, > > Andrew Schwartzmeyer > > --===============5019995281243988005==--