From reviews-return-73470-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Feb 16 14:13:18 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4653817D2E for ; Fri, 16 Feb 2018 14:13:18 +0000 (UTC) Received: (qmail 43257 invoked by uid 500); 16 Feb 2018 14:13:18 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 43223 invoked by uid 500); 16 Feb 2018 14:13:18 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 43196 invoked by uid 99); 16 Feb 2018 14:13:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 14:13:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0883BC02A4; Fri, 16 Feb 2018 14:13:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id poqEGIF9H27Y; Fri, 16 Feb 2018 14:13:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8AFEF5F18B; Fri, 16 Feb 2018 14:13:15 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E163CE00C9; Fri, 16 Feb 2018 14:13:14 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B557CC401F5; Fri, 16 Feb 2018 14:13:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7374586839689982151==" MIME-Version: 1.0 Subject: Re: Review Request 65482: Improved handling of non-terminal operations after master failover. From: Benjamin Bannier To: Jie Yu , Jan Schlicht , Greg Mann Cc: Benjamin Bannier , Mesos Reviewbot Windows , Gaston Kleiman , mesos Date: Fri, 16 Feb 2018 14:13:14 -0000 Message-ID: <20180216141314.31721.10175@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65482/ X-Sender: Benjamin Bannier References: <20180216001334.58252.14560@reviews-vm2.apache.org> In-Reply-To: <20180216001334.58252.14560@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============7374586839689982151== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 16, 2018, 1:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 7652 (patched) > > > > > > s/ "operation/<< "operation/ I don't think we need or want an extra function call here. I ended up moving the space from the previous line to this one though. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review197651 ----------------------------------------------------------- On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65482/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 3:12 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht. > > > Bugs: MESOS-8536 > https://issues.apache.org/jira/browse/MESOS-8536 > > > Repository: mesos > > > Description > ------- > > This patch fixes the handling of non-terminal operations learned by a > newly elected master after a master failover, so that only these > operations are counted as using resources. Previously we did not count > any operations as using resources which by accident produced expected > behavior if the operation was already terminal when the master learned > about them. > > We do not address the issue of being unable to properly account for > operations triggered by frameworks unknown to the master, see > MESOS-8582. Instead we emit a warning for now since the master might > continue to abort due to assertion failures due to incomplete resource > accounting. > > > Diffs > ----- > > src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d > > > Diff: https://reviews.apache.org/r/65482/diff/4/ > > > Testing > ------- > > `make check`, also tested with a version of the test added in r/65045 which triggered this issue. > > > Thanks, > > Benjamin Bannier > > --===============7374586839689982151==--