From reviews-return-73467-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Fri Feb 16 14:13:03 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C7F2117D17 for ; Fri, 16 Feb 2018 14:13:03 +0000 (UTC) Received: (qmail 40881 invoked by uid 500); 16 Feb 2018 14:13:03 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 40850 invoked by uid 500); 16 Feb 2018 14:13:03 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 40251 invoked by uid 99); 16 Feb 2018 14:13:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Feb 2018 14:13:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 88E40C0238; Fri, 16 Feb 2018 14:13:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id UbZeuzl2nZDh; Fri, 16 Feb 2018 14:13:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 428525F18B; Fri, 16 Feb 2018 14:13:00 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9207CE00C9; Fri, 16 Feb 2018 14:12:59 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 7A0B0C401F5; Fri, 16 Feb 2018 14:12:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1290701171242704067==" MIME-Version: 1.0 Subject: Re: Review Request 65591: Explicitly tracked resource providers in master. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , Mesos Reviewbot Windows , Gaston Kleiman , Mesos Reviewbot , mesos Date: Fri, 16 Feb 2018 14:12:59 -0000 Message-ID: <20180216141259.31720.86929@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65591/ X-Sender: Benjamin Bannier References: <20180216011339.58054.62199@reviews-vm2.apache.org> In-Reply-To: <20180216011339.58054.62199@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============1290701171242704067== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Line 7307 (original), 7351 (patched) > > > > > > Do we plan to support resource providers with info (so not the agent-default resources), but without an ID? > > > > Line 7470 indicates that we don't. Added `CHECK`s here as well. > On Feb. 16, 2018, 2:13 a.m., Gaston Kleiman wrote: > > src/master/master.cpp > > Lines 7516 (patched) > > > > > > It doesnt look like `operation_` is used after this line. Can we revert to inlining the creation of the operation? Like the comment above indicated this should have updated `operations`, fixed the code. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197652 ----------------------------------------------------------- On Feb. 16, 2018, 3:12 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65591/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 3:12 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-8382 > https://issues.apache.org/jira/browse/MESOS-8382 > > > Repository: mesos > > > Description > ------- > > This patch adds explicit tracking of resource providers to the master > process. While we already had explicitly send resource provider > information in e.g., `UpdateSlaveMessage`, we only stored that > information aggregated over the full agent in the master up to now. > > > Diffs > ----- > > src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f > src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 > src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d > > > Diff: https://reviews.apache.org/r/65591/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > > --===============1290701171242704067==--