From reviews-return-73443-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Feb 15 14:54:16 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E017F18A83 for ; Thu, 15 Feb 2018 14:54:16 +0000 (UTC) Received: (qmail 11431 invoked by uid 500); 15 Feb 2018 14:54:16 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 11396 invoked by uid 500); 15 Feb 2018 14:54:16 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 11107 invoked by uid 99); 15 Feb 2018 14:54:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Feb 2018 14:54:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A10DCC0188; Thu, 15 Feb 2018 14:54:15 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.941 X-Spam-Level: X-Spam-Status: No, score=0.941 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Va2oCKUDZrpr; Thu, 15 Feb 2018 14:54:14 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AEE465F18D; Thu, 15 Feb 2018 14:54:13 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 085BFE0115; Thu, 15 Feb 2018 14:54:13 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 12EB9C409AF; Thu, 15 Feb 2018 14:54:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4140976587389256202==" MIME-Version: 1.0 Subject: Re: Review Request 65591: Explicitly tracked resource providers in master. From: Benjamin Bannier To: Jie Yu , Jan Schlicht Cc: Benjamin Bannier , Mesos Reviewbot , mesos , Mesos Reviewbot Windows Date: Thu, 15 Feb 2018 14:54:11 -0000 Message-ID: <20180215145411.58301.18876@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Benjamin Bannier X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65591/ X-Sender: Benjamin Bannier References: <20180209172741.47223.65196@reviews-vm2.apache.org> In-Reply-To: <20180209172741.47223.65196@reviews-vm2.apache.org> Reply-To: Benjamin Bannier X-ReviewRequest-Repository: mesos --===============4140976587389256202== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ ----------------------------------------------------------- (Updated Feb. 15, 2018, 3:54 p.m.) Review request for mesos, Jie Yu and Jan Schlicht. Changes ------- * addressed comments from Jan * re-added reconciliation of operations on agent-default resources Bugs: MESOS-8382 https://issues.apache.org/jira/browse/MESOS-8382 Repository: mesos Description ------- This patch adds explicit tracking of resource providers to the master process. While we already had explicitly send resource provider information in e.g., `UpdateSlaveMessage`, we only stored that information aggregated over the full agent in the master up to now. Diffs (updated) ----- src/common/protobuf_utils.cpp b5c2997ada8362e42150fa3cfd762120e5ea715f src/master/master.hpp c4d3c8080dc7899968b1030696172ed73d473bc1 src/master/master.cpp b06d7a6e2fbbb81b97eaf537d5b6745c73dc867d Diff: https://reviews.apache.org/r/65591/diff/2/ Changes: https://reviews.apache.org/r/65591/diff/1-2/ Testing ------- `make check` Thanks, Benjamin Bannier --===============4140976587389256202==--