----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65556/#review197506 ----------------------------------------------------------- Fix it, then Ship it! src/launcher/default_executor.cpp Lines 1538-1539 (patched) A newline between. - Qian Zhang On Feb. 13, 2018, 7:08 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65556/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 7:08 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8468 > https://issues.apache.org/jira/browse/MESOS-8468 > > > Repository: mesos > > > Description > ------- > > This patch makes the default executor not shutdown if there it there are > active child containers, and it fails to connect or is not subscribed to > the agent when starting to launch a task group. > > > Diffs > ----- > > src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea > > > Diff: https://reviews.apache.org/r/65556/diff/4/ > > > Testing > ------- > > `sudo make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >