----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197470 ----------------------------------------------------------- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4841 (patched) Dispatch this in the slave's context. src/tests/slave_tests.cpp Lines 4852-4854 (patched) These are not required since `exitedExecutorMessage` is processed synchronously in the master's context. src/tests/slave_tests.cpp Lines 4986 (patched) Ditto. src/tests/slave_tests.cpp Lines 4997-4999 (patched) Ditto. - Chun-Hung Hsiao On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65593/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 6:26 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1720 > https://issues.apache.org/jira/browse/MESOS-1720 > > > Repository: mesos > > > Description > ------- > > Theses tests ensure that agent sends ExitedExecutorMessage when the > task group fails to launch due to unschedule GC failure and when > the task fails to launch due to task authorization failure. > So that master's executor bookkeeping entry is removed. > > > Diffs > ----- > > src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 > > > Diff: https://reviews.apache.org/r/65593/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >