From reviews-return-73395-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Wed Feb 14 03:25:47 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3380E17B00 for ; Wed, 14 Feb 2018 03:25:47 +0000 (UTC) Received: (qmail 31911 invoked by uid 500); 14 Feb 2018 03:25:47 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 31878 invoked by uid 500); 14 Feb 2018 03:25:47 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 31861 invoked by uid 99); 14 Feb 2018 03:25:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Feb 2018 03:25:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D588C1A0723; Wed, 14 Feb 2018 03:25:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id M4EPgTVUTo9j; Wed, 14 Feb 2018 03:25:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34B8F5F3B9; Wed, 14 Feb 2018 03:25:44 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 532B2E0026; Wed, 14 Feb 2018 03:25:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id A2DAFC405C2; Wed, 14 Feb 2018 03:25:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5254616087960060104==" MIME-Version: 1.0 Subject: Re: Review Request 65593: Added tests to check executor that failed to launch is removed. From: Chun-Hung Hsiao To: Vinod Kone Cc: Meng Zhu , Chun-Hung Hsiao , mesos Date: Wed, 14 Feb 2018 03:25:41 -0000 Message-ID: <20180214032541.2972.46762@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Chun-Hung Hsiao X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65593/ X-Sender: Chun-Hung Hsiao X-ReviewBoard-ShipIt: 1 References: <20180213062653.2972.53517@reviews-vm2.apache.org> In-Reply-To: <20180213062653.2972.53517@reviews-vm2.apache.org> Reply-To: Chun-Hung Hsiao X-ReviewRequest-Repository: mesos --===============5254616087960060104== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65593/#review197470 ----------------------------------------------------------- Fix it, then Ship it! src/tests/slave_tests.cpp Lines 4841 (patched) Dispatch this in the slave's context. src/tests/slave_tests.cpp Lines 4852-4854 (patched) These are not required since `exitedExecutorMessage` is processed synchronously in the master's context. src/tests/slave_tests.cpp Lines 4986 (patched) Ditto. src/tests/slave_tests.cpp Lines 4997-4999 (patched) Ditto. - Chun-Hung Hsiao On Feb. 13, 2018, 6:26 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65593/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2018, 6:26 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1720 > https://issues.apache.org/jira/browse/MESOS-1720 > > > Repository: mesos > > > Description > ------- > > Theses tests ensure that agent sends ExitedExecutorMessage when the > task group fails to launch due to unschedule GC failure and when > the task fails to launch due to task authorization failure. > So that master's executor bookkeeping entry is removed. > > > Diffs > ----- > > src/tests/slave_tests.cpp 628b0d0fc862264c9553e1660c7df548df9cd4a1 > > > Diff: https://reviews.apache.org/r/65593/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > > --===============5254616087960060104==--