From reviews-return-73348-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Tue Feb 13 04:41:14 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7AB0A189BD for ; Tue, 13 Feb 2018 04:41:14 +0000 (UTC) Received: (qmail 35749 invoked by uid 500); 13 Feb 2018 04:41:14 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 35709 invoked by uid 500); 13 Feb 2018 04:41:14 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 35694 invoked by uid 99); 13 Feb 2018 04:41:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Feb 2018 04:41:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B229A1A060D; Tue, 13 Feb 2018 04:41:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id htjCSRjrIbFk; Tue, 13 Feb 2018 04:41:11 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 985BB5F398; Tue, 13 Feb 2018 04:41:10 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E56ADE0047; Tue, 13 Feb 2018 04:41:09 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 62498C40017; Tue, 13 Feb 2018 04:41:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9176761631326227469==" MIME-Version: 1.0 Subject: Review Request 65624: Added fetcher tests for `stderr` output. From: Andrew Schwartzmeyer To: Akash Gupta , Joseph Wu Cc: Andrew Schwartzmeyer , mesos Date: Tue, 13 Feb 2018 04:41:08 -0000 Message-ID: <20180213044108.6750.91342@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Andrew Schwartzmeyer X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65624/ X-Sender: Andrew Schwartzmeyer Reply-To: Andrew Schwartzmeyer X-ReviewRequest-Repository: mesos --===============9176761631326227469== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65624/ ----------------------------------------------------------- Review request for mesos, Akash Gupta and Joseph Wu. Repository: mesos Description ------- The fetcher is supposed to log its `stderr` output to a redirected file called `stderr` in the given sandbox directory. There previously existed a bug on Windows due to incorrect handle inheritance where this redirection failed silently, leaving the log empty. These unit tests assert that the correct content is logged to the `stderr` file for both a success and failure fetch scenario. Diffs ----- src/tests/fetcher_tests.cpp 1b4ba1d286f218731c13180e5189e91f90e3d63f Diff: https://reviews.apache.org/r/65624/diff/1/ Testing ------- Windows (Linux pending): ``` [ RUN ] FetcherTest.LogSuccessToStderr [ OK ] FetcherTest.LogSuccessToStderr (197 ms) [ RUN ] FetcherTest.LogFailureToStderr [ OK ] FetcherTest.LogFailureToStderr (320 ms) ``` Thanks, Andrew Schwartzmeyer --===============9176761631326227469==--