From reviews-return-73094-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Feb 8 18:02:31 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8F45186E4 for ; Thu, 8 Feb 2018 18:02:30 +0000 (UTC) Received: (qmail 51114 invoked by uid 500); 8 Feb 2018 18:02:30 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 51072 invoked by uid 500); 8 Feb 2018 18:02:30 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 51057 invoked by uid 99); 8 Feb 2018 18:02:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 18:02:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AFB0BC0042; Thu, 8 Feb 2018 18:02:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id J95UpThNAA1S; Thu, 8 Feb 2018 18:02:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8A19D5F343; Thu, 8 Feb 2018 18:02:27 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CDA35E0047; Thu, 8 Feb 2018 18:02:26 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 11085C401B6; Thu, 8 Feb 2018 18:02:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2460555350169082745==" MIME-Version: 1.0 Subject: Re: Review Request 65571: Handle 'None' passed from the MasterDetector in 'Master::detect()'. From: Mesos Reviewbot Windows To: Andrei Budnik , Vinod Kone Cc: Mesos Reviewbot Windows , Benno Evers , mesos Date: Thu, 08 Feb 2018 18:02:24 -0000 Message-ID: <20180208180224.11383.75874@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Mesos Reviewbot Windows X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65571/ X-Sender: Mesos Reviewbot Windows References: <20180208165042.11085.79458@reviews-vm2.apache.org> In-Reply-To: <20180208165042.11085.79458@reviews-vm2.apache.org> Reply-To: Mesos Reviewbot Windows X-ReviewRequest-Repository: mesos --===============2460555350169082745== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65571/#review197095 ----------------------------------------------------------- PASS: Mesos patch 65571 was successfully built and tested. Reviews applied: `['65571']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65571 - Mesos Reviewbot Windows On Feb. 8, 2018, 4:50 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65571/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 4:50 p.m.) > > > Review request for mesos, Andrei Budnik and Vinod Kone. > > > Bugs: MESOS-8550 > https://issues.apache.org/jira/browse/MESOS-8550 > > > Repository: mesos > > > Description > ------- > > The function `MasterDetector::detect()` returns a value of type > `Future>`, which, according to its documentation, > can be `None` if an election occured and no master is elected. > > However, the code in `Master::detected()` was only handling the > cases of a failed future or a valid `MasterInfo` object. > > > Diffs > ----- > > src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381 > src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9 > src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1 > > > Diff: https://reviews.apache.org/r/65571/diff/1/ > > > Testing > ------- > > `./mesos-tests` > > > Thanks, > > Benno Evers > > --===============2460555350169082745==--