From reviews-return-73058-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Feb 8 01:36:31 2018 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E5B3D17D37 for ; Thu, 8 Feb 2018 01:36:31 +0000 (UTC) Received: (qmail 52801 invoked by uid 500); 8 Feb 2018 01:36:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 52768 invoked by uid 500); 8 Feb 2018 01:36:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 52677 invoked by uid 99); 8 Feb 2018 01:36:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Feb 2018 01:36:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DEDA11A09EB; Thu, 8 Feb 2018 01:36:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.94 X-Spam-Level: X-Spam-Status: No, score=0.94 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_MED=-2.3, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lqzpLtZYKjYz; Thu, 8 Feb 2018 01:36:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6A8565F11F; Thu, 8 Feb 2018 01:36:28 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A2342E00A3; Thu, 8 Feb 2018 01:36:27 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 8C3F1C401BF; Thu, 8 Feb 2018 01:36:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0289931434552671677==" MIME-Version: 1.0 Subject: Re: Review Request 65541: WIP: Experimented with the MessageDifferencer. From: Joseph Wu To: Benjamin Mahler Cc: Mesos Reviewbot Windows , Joseph Wu , mesos Date: Thu, 08 Feb 2018 01:36:27 -0000 Message-ID: <20180208013627.29731.21834@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/65541/ X-Sender: Joseph Wu References: <20180207032535.26832.54298@reviews-vm2.apache.org> In-Reply-To: <20180207032535.26832.54298@reviews-vm2.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos --===============0289931434552671677== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65541/ ----------------------------------------------------------- (Updated Feb. 7, 2018, 5:36 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Added some consideration for the `Resources` object, still has some edge cases that I haven't figured out how to work around yet (see a TODO). Bugs: MESOS-2487 https://issues.apache.org/jira/browse/MESOS-2487 Repository: mesos Description ------- This is an attempt to use the MessageDifferencer class (introduced in protobuf 3.0) to replace our handwritten protobuf equality operators. This patch currently: * Ignores style rules (mostly). * Has TODOs to deal with the Resources and Attributes classes, which have their own wrappers and may need to be special-cased. * Only deals with non-versioned protobufs at the moment. * Can be made faster by making the MessageDifferencer into a `static thread_local` object guarded by a Once. Diffs (updated) ----- include/mesos/type_utils.hpp af2b187b9b59552e4ba515ad640fd4419eaf5075 src/common/type_utils.cpp a4d5dcb4e4445e307356d9b0c16dd39f00f6a8e2 Diff: https://reviews.apache.org/r/65541/diff/2/ Changes: https://reviews.apache.org/r/65541/diff/1-2/ Testing ------- Thanks, Joseph Wu --===============0289931434552671677==--