| Mesos Reviewbot Windows |
Re: Review Request 65045: Tested correct operation handling during master failover. |
Fri, 02 Feb, 22:21 |
| Mesos Reviewbot Windows |
Re: Review Request 65437: Added documentation for fault domains. |
Fri, 02 Feb, 22:22 |
| Mesos Reviewbot Windows |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Fri, 02 Feb, 22:22 |
| Jie Yu |
Review Request 65491: Added metrics for CSI plugin terminations. |
Fri, 02 Feb, 22:40 |
| Mesos Reviewbot Windows |
Re: Review Request 65491: Added metrics for CSI plugin terminations. |
Fri, 02 Feb, 22:41 |
| Chun-Hung Hsiao |
Re: Review Request 65491: Added metrics for CSI plugin terminations. |
Fri, 02 Feb, 23:05 |
| Greg Mann |
Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover. |
Fri, 02 Feb, 23:05 |
| Greg Mann |
Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover. |
Fri, 02 Feb, 23:06 |
| Vinod Kone |
Re: Review Request 65449: Fixed an issue where executor info linger on master if failed to launch. |
Fri, 02 Feb, 23:08 |
| Benjamin Mahler |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Fri, 02 Feb, 23:14 |
| Benjamin Mahler |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Fri, 02 Feb, 23:15 |
| Benjamin Mahler |
Re: Review Request 65474: Updated socket shutdown to return SocketError. |
Fri, 02 Feb, 23:23 |
| Chun-Hung Hsiao |
Re: Review Request 65447: Refactored couple of launch task sanity checks into a single code path. |
Fri, 02 Feb, 23:28 |
| Till Toenshoff |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Fri, 02 Feb, 23:41 |
| Benjamin Mahler |
Re: Review Request 65461: Provide new overload of 'ProcessBase::route()'. |
Sat, 03 Feb, 00:06 |
| Jie Yu |
Review Request 65492: Changed the SLRP test fixture. |
Sat, 03 Feb, 00:08 |
| Mesos Reviewbot Windows |
Re: Review Request 65492: Changed the SLRP test fixture. |
Sat, 03 Feb, 00:11 |
| Chun-Hung Hsiao |
Re: Review Request 65492: Changed the SLRP test fixture. |
Sat, 03 Feb, 00:14 |
| Andrei Budnik |
Re: Review Request 65474: Updated socket shutdown to return SocketError. |
Sat, 03 Feb, 00:41 |
| Mesos Reviewbot Windows |
Re: Review Request 65464: Introduced `mesos-build` along with pre-built docker images. |
Sat, 03 Feb, 00:41 |
| Chun-Hung Hsiao |
Review Request 65495: Fixed clang compilation problem for the SLRP metrics test. |
Sat, 03 Feb, 00:56 |
| Mesos Reviewbot Windows |
Re: Review Request 65495: Fixed clang compilation problem for the SLRP metrics test. |
Sat, 03 Feb, 01:01 |
| Jie Yu |
Re: Review Request 65495: Fixed clang compilation problem for the SLRP metrics test. |
Sat, 03 Feb, 01:08 |
| Meng Zhu |
Review Request 65496: Fixed a bug where task-less v1 executor could linger. |
Sat, 03 Feb, 01:17 |
| Meng Zhu |
Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing. |
Sat, 03 Feb, 01:18 |
| Mesos Reviewbot Windows |
Re: Review Request 65497: Added test to verify task-less executor is shutdown when re-subscribing. |
Sat, 03 Feb, 01:21 |
| Chun-Hung Hsiao |
Re: Review Request 65060: Cleaned up endpoint directories after SLRP tests. |
Sat, 03 Feb, 01:37 |
| Chun-Hung Hsiao |
Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test. |
Sat, 03 Feb, 01:39 |
| Mesos Reviewbot Windows |
Re: Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test. |
Sat, 03 Feb, 01:41 |
| Till Toenshoff |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Sat, 03 Feb, 04:48 |
| Till Toenshoff |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Sat, 03 Feb, 04:48 |
| Mesos Reviewbot Windows |
Re: Review Request 65475: Fixed SSL socket shutdown returned errno. |
Sat, 03 Feb, 04:51 |
| Michael Park |
Re: Review Request 65464: Introduced `mesos-build` along with pre-built docker images. |
Sun, 04 Feb, 01:14 |
| Armand Grillet |
Re: Review Request 64211: Added options to build the Python CLI and run unit tests. |
Sun, 04 Feb, 18:07 |
| Armand Grillet |
Re: Review Request 65246: Added download button for master and agent logs in Web UI. |
Sun, 04 Feb, 19:31 |
| Michael Park |
Re: Review Request 65464: Introduced `mesos-build` along with pre-built docker images. |
Sun, 04 Feb, 20:22 |
| Armand Grillet |
Review Request 65503: Added bootstrap-table library for the WebUI. |
Sun, 04 Feb, 21:12 |
| Armand Grillet |
Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. |
Sun, 04 Feb, 21:18 |
| Meng Zhu |
Re: Review Request 65445: Added new protobuf field `launch_executor` in RunTask(Group)Message. |
Mon, 05 Feb, 02:44 |
| Meng Zhu |
Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`. |
Mon, 05 Feb, 02:45 |
| Meng Zhu |
Re: Review Request 65446: Added helper function for the agent to send `ExitedExecutorMessage`. |
Mon, 05 Feb, 02:46 |
| Meng Zhu |
Review Request 65504: Made master set `launch_executor` in the RunTask(Group)Message. |
Mon, 05 Feb, 02:49 |
| Meng Zhu |
Re: Review Request 65449: Fixed an issue where executor info linger on master if failed to launch. |
Mon, 05 Feb, 03:00 |
| Mesos Reviewbot Windows |
Re: Review Request 65464: Introduced `mesos-build` along with pre-built docker images. |
Mon, 05 Feb, 06:42 |
| Mesos Reviewbot Windows |
Re: Review Request 65246: Added download button for master and agent logs in Web UI. |
Mon, 05 Feb, 06:42 |
| Mesos Reviewbot Windows |
Re: Review Request 64211: Added options to build the Python CLI and run unit tests. |
Mon, 05 Feb, 07:28 |
| Mesos Reviewbot Windows |
Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. |
Mon, 05 Feb, 07:31 |
| Alexander Rojas |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Mon, 05 Feb, 10:57 |
| Alexander Rojas |
Re: Review Request 65312: Refactored authorization logic in the master. |
Mon, 05 Feb, 10:58 |
| Alexander Rojas |
Re: Review Request 65313: Refactored authorization logic in the agent. |
Mon, 05 Feb, 10:58 |
| Alexander Rojas |
Re: Review Request 65314: Removed code which is not used. |
Mon, 05 Feb, 10:59 |
| Benjamin Bannier |
Re: Review Request 65439: Made cleanliness checks in post-reviews.py less strict. |
Mon, 05 Feb, 11:22 |
| Mesos Reviewbot Windows |
Re: Review Request 65314: Removed code which is not used. |
Mon, 05 Feb, 11:47 |
| Alexander Rojas |
Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic. |
Mon, 05 Feb, 13:52 |
| Alexander Rojas |
Re: Review Request 65314: Removed code which is not used. |
Mon, 05 Feb, 13:52 |
| Mesos Reviewbot Windows |
Re: Review Request 65314: Removed code which is not used. |
Mon, 05 Feb, 14:48 |
| Andrei Budnik |
Review Request 65505: Restored `WaitAfterDestroy` test for a nested container. |
Mon, 05 Feb, 15:53 |
| Mesos Reviewbot Windows |
Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests. |
Mon, 05 Feb, 16:31 |
| Mesos Reviewbot Windows |
Re: Review Request 65505: Restored `WaitAfterDestroy` test for a nested container. |
Mon, 05 Feb, 17:19 |
| Benjamin Bannier |
Review Request 65506: Used `dispatch` instead of `defer` for offer callbacks. |
Mon, 05 Feb, 17:46 |
| Benjamin Mahler |
Re: Review Request 65506: Used `dispatch` instead of `defer` for offer callbacks. |
Mon, 05 Feb, 18:03 |
| Jeff Coffler |
Review Request 65508: Allow curl program to be properly executed on Windows platform. |
Mon, 05 Feb, 18:12 |
| Mesos Reviewbot Windows |
Re: Review Request 65506: Used `dispatch` instead of `defer` for offer callbacks. |
Mon, 05 Feb, 18:38 |
| Benjamin Bannier |
Re: Review Request 65348: Fixed flakyness of MasterTest.UpdateSlaveMessageWithPendingOffers. |
Mon, 05 Feb, 18:55 |
| Till Toenshoff |
Review Request 65512: Fixed race in Python egg caching. |
Mon, 05 Feb, 19:15 |
| Mesos Reviewbot Windows |
Re: Review Request 65508: Allow curl program to be properly executed on Windows platform. |
Mon, 05 Feb, 19:24 |
| Vinod Kone |
Re: Review Request 65512: Fixed race in Python egg caching. |
Mon, 05 Feb, 19:33 |
| Benjamin Bannier |
Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover. |
Mon, 05 Feb, 19:42 |
| Benjamin Bannier |
Re: Review Request 65482: Fixed allocator bookkeeping of pending operations on master failover. |
Mon, 05 Feb, 19:42 |
| Till Toenshoff |
Re: Review Request 65512: Fixed race in Python egg caching. |
Mon, 05 Feb, 19:50 |
| Jeff Coffler |
Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows. |
Mon, 05 Feb, 19:53 |
| Jeff Coffler |
Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform. |
Mon, 05 Feb, 19:54 |
| Mesos Reviewbot Windows |
Re: Review Request 65512: Fixed race in Python egg caching. |
Mon, 05 Feb, 20:15 |
| Meng Zhu |
Re: Review Request 65334: Added quota limit to the master API protos. |
Mon, 05 Feb, 20:34 |
| Mesos Reviewbot Windows |
Re: Review Request 65510: Enable 'curl' uri_fetcher tests on Windows platform. |
Mon, 05 Feb, 21:03 |
| Mesos Reviewbot Windows |
Re: Review Request 65334: Added quota limit to the master API protos. |
Mon, 05 Feb, 21:49 |
| Benjamin Mahler |
Review Request 65514: Introduced a CHECK_NOTERROR macro. |
Mon, 05 Feb, 22:06 |
| Benjamin Mahler |
Review Request 65515: Added rvalue reference Try::get overloads. |
Mon, 05 Feb, 22:08 |
| Mesos Reviewbot Windows |
Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests. |
Mon, 05 Feb, 22:31 |
| Mesos Reviewbot Windows |
Re: Review Request 65515: Added rvalue reference Try::get overloads. |
Mon, 05 Feb, 22:47 |
| James Peach |
Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests. |
Mon, 05 Feb, 22:50 |
| Till Toenshoff |
Re: Review Request 65474: Updated socket shutdown to return SocketError. |
Mon, 05 Feb, 22:51 |
| Mesos Reviewbot Windows |
Re: Review Request 65202: Adopted `DEFAULT_TEST_TIMEOUT` in Mesos tests. |
Mon, 05 Feb, 23:37 |
| Michael Park |
Re: Review Request 65512: Fixed race in Python egg caching. |
Mon, 05 Feb, 23:49 |
| Mesos Reviewbot Windows |
Re: Review Request 65509: The CURL_ prefix in unit test name should always succeed on Windows. |
Tue, 06 Feb, 00:43 |
| Qian Zhang |
Review Request 65518: Reaped the container process directly in Docker executor. |
Tue, 06 Feb, 02:54 |
| Benjamin Mahler |
Re: Review Request 65503: Added bootstrap-table library for the WebUI. |
Tue, 06 Feb, 03:26 |
| Mesos Reviewbot Windows |
Re: Review Request 65512: Fixed race in Python egg caching. |
Tue, 06 Feb, 03:37 |
| Benjamin Mahler |
Re: Review Request 65346: Updated Web UI to show quota guarantee and limit for roles. |
Tue, 06 Feb, 03:38 |
| Chun-Hung Hsiao |
Review Request 65520: Reverted plugin name randomization in SLRP tests. |
Tue, 06 Feb, 04:08 |
| Chun-Hung Hsiao |
Review Request 65523: Fixed a bug in the SLRP metrics test. |
Tue, 06 Feb, 04:09 |
| Chun-Hung Hsiao |
Review Request 65521: Improved isolation for agent RP API config tests. |
Tue, 06 Feb, 04:11 |
| Chun-Hung Hsiao |
Re: Review Request 65061: Speeded up tests for resource provider config agent API. |
Tue, 06 Feb, 04:14 |
| Chun-Hung Hsiao |
Re: Review Request 65062: Cleaned up endpoint directories after RP config agent API tests. |
Tue, 06 Feb, 04:15 |
| Chun-Hung Hsiao |
Review Request 65522: Fixed some log messages in `slave.cpp`. |
Tue, 06 Feb, 04:17 |
| Mesos Reviewbot Windows |
Re: Review Request 65518: Reaped the container process directly in Docker executor. |
Tue, 06 Feb, 04:24 |
| Chun-Hung Hsiao |
Re: Review Request 65523: Fixed a bug in the SLRP metrics test. |
Tue, 06 Feb, 04:58 |
| Mesos Reviewbot Windows |
Re: Review Request 65522: Fixed some log messages in `slave.cpp`. |
Tue, 06 Feb, 05:06 |
| Armand Grillet |
Re: Review Request 65246: Added download button for master and agent logs in Web UI. |
Tue, 06 Feb, 06:05 |
| Mesos Reviewbot |
Re: Review Request 65314: Removed code which is not used. |
Tue, 06 Feb, 07:52 |