mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 65842: Changed `os::spawn` to return `Option<int>` instead of `int`.
Date Wed, 28 Feb 2018 18:15:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65842/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.


Bugs: MESOS-4549
    https://issues.apache.org/jira/browse/MESOS-4549


Repository: mesos


Description
-------

Similar to `os::system`, `os::spawn` returned -1 on error, which is a
valid exit code on Windows. Using the same solution for `os::system`,
now when `os::spawn` fails, `None` will be returned. Otherwise, the
process exit code will be returned.


Diffs
-----

  3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360

  3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d

  3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c

  src/linux/fs.cpp dae094224321c0974c705023daf076409049de51 
  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp c60c23f74f2abf6bef8dd32cc2e47e33bf666169

  src/tests/containerizer/perf_tests.cpp d8aab08eb131f974821fb85662cbc6cc685d2f3e 


Diff: https://reviews.apache.org/r/65842/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message