mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 65839: Windows: Removed W* test-only macros in `windows.hpp`.
Date Wed, 28 Feb 2018 18:09:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65839/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.


Repository: mesos


Description
-------

`windows.hpp` defined a few macros for the status value of `waitpid`
that were either unused in the code base or were only used in gtest.
These macros handled signal logic, so they were removed since they
aren't used on Windows.


Diffs
-----

  3rdparty/libprocess/include/process/gtest.hpp dd4c9bdf7e6e0e45db347108fde3b41960974be6 
  3rdparty/stout/include/stout/gtest.hpp ce6e4de6a9f69ea121ff0ca6048316d678c8c857 
  3rdparty/stout/include/stout/windows.hpp b35e6b94ba6709254450be9429b6f48f2d276689 
  src/checks/checker_process.cpp cf9ec053946e620eb36e92d647ab864c4e88d506 


Diff: https://reviews.apache.org/r/65839/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message