mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sachin Paryani <sachin.pary...@gmail.com>
Subject Review Request 65799: Ported mesos-master to Windows.
Date Sun, 25 Feb 2018 03:19:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65799/
-----------------------------------------------------------

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-5820
    https://issues.apache.org/jira/browse/MESOS-5820


Repository: mesos


Description
-------

The change allows for the mesos-master executable to work on Windows.
The change was to remove the part of the code for that utilizes the
ip_discovery_command flag if the build is Windows and replaced with
an appropriate error message.


Diffs
-----

  src/master/CMakeLists.txt ec552110509d17628107f4ad98f2d04675ed3ce3 
  src/master/main.cpp 8cb52d0c452ab3c328eea80aa56f1c984de372e9 


Diff: https://reviews.apache.org/r/65799/diff/1/


Testing
-------

Successfully built the master and then started the mesos-master executable.  
The following command was used:
./src/mesos-master --registry='in_memory' --webui_dir=../src/webui


Thanks,

Sachin Paryani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message