mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 65514: Introduced a CHECK_NOTERROR macro.
Date Fri, 23 Feb 2018 22:44:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65514/#review198217
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/check.hpp
Lines 123 (patched)
<https://reviews.apache.org/r/65514/#comment278331>

    Ideally `t.error()` here would always return the `E` and we can simply access the message
via `t.error().message`, but it returns `string` when `E == Error` for backward-compatibility.
    
    One approach here would be to do `string(t.error())` and add a `operator const string&()`
to `Error`.


- Michael Park


On Feb. 5, 2018, 2:06 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65514/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2018, 2:06 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/check.hpp 6a33579b6c7590590fd3157e14cdc72bcc2bc27b 
> 
> 
> Diff: https://reviews.apache.org/r/65514/diff/1/
> 
> 
> Testing
> -------
> 
> make check, used in a subsequent patch
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message