mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 65750: Added test for a hung 'docker inspect' during container pull.
Date Fri, 23 Feb 2018 22:42:45 GMT


> On Feb. 23, 2018, 6:12 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5251-5258 (patched)
> > <https://reviews.apache.org/r/65750/diff/2/?file=1963502#file1963502line5251>
> >
> >     Instead of following the style in this file, could we do `createTask()`?

I used the `createTask` helper, but since we don't have an overload which accepts a ContainerInfo
I still had to modify the TaskInfo. We could add a new overload in the future perhaps.


> On Feb. 23, 2018, 6:12 p.m., Gilbert Song wrote:
> > src/tests/containerizer/docker_containerizer_tests.cpp
> > Lines 5284-5285 (patched)
> > <https://reviews.apache.org/r/65750/diff/2/?file=1963502#file1963502line5284>
> >
> >     Could we also verify that the statusFailed's reason is due to TIMEOUT?

The reason is actually due to container launch failure - I think this makes sense, since although
the executor registration timeout triggers the status update, the container was never launched
successfully. I added an expectation to check this.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65750/#review198195
-----------------------------------------------------------


On Feb. 23, 2018, 10:41 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65750/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2018, 10:41 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test for a hung 'docker inspect' during container pull.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

> 
> 
> Diff: https://reviews.apache.org/r/65750/diff/3/
> 
> 
> Testing
> -------
> 
> sudo bin/mesos-tests.sh --gtest_filter="HungDockerTest.ROOT_DOCKER_InspectDuringPull"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message