mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 64604: Windows: Updated heath-checks.md with Windows implementation.
Date Thu, 22 Feb 2018 12:09:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64604/#review198110
-----------------------------------------------------------


Fix it, then Ship it!





docs/health-checks.md
Lines 384-386 (original), 384-387 (patched)
<https://reviews.apache.org/r/64604/#comment278218>

    You need the same change for HTTP checks.



docs/health-checks.md
Lines 425-426 (original), 426-429 (patched)
<https://reviews.apache.org/r/64604/#comment278219>

    You need the same for TCP checks


- Alexander Rukletsov


On Feb. 22, 2018, 1:50 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64604/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 1:50 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
Jie Yu, and Michael Park.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated health-checks.md with details of the Windows health check
> implementations for the mesos and docker executors.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md 119d149f29f2f2d3178da6ef63a7ce97a4dbc952 
> 
> 
> Diff: https://reviews.apache.org/r/64604/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message