mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 65127: Windows: Enabled docker health checks.
Date Thu, 22 Feb 2018 11:17:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65127/#review198107
-----------------------------------------------------------


Fix it, then Ship it!





src/checks/checker_process.cpp
Lines 1157 (patched)
<https://reviews.apache.org/r/65127/#comment278212>

    maybe `dockerNetworkRunArgs` or `dockerNetworkRunCommand`?



src/checks/checker_process.cpp
Lines 1153-1154 (original), 1179-1181 (patched)
<https://reviews.apache.org/r/65127/#comment278213>

    I'd move this explanation in front of the function declaration and here leave a shorter
note.



src/checks/checker_process.cpp
Lines 1187 (patched)
<https://reviews.apache.org/r/65127/#comment278214>

    `toAdd` is vague. Maybe `httpCheckCommandParameters`?



src/checks/checker_process.cpp
Lines 1202 (patched)
<https://reviews.apache.org/r/65127/#comment278211>

    `cbegin() / cend()` please



src/checks/checker_process.cpp
Lines 1367 (patched)
<https://reviews.apache.org/r/65127/#comment278215>

    `cbegin / cend`


- Alexander Rukletsov


On Feb. 22, 2018, 1:46 a.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65127/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 1:46 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The network health checks called curl and then executed setns to
> enter to container network namespace, which did not work on Windows.
> To do the equivalent, Windows nows calls docker run with powershell's
> curl equivalent (Invoke-WebRequest) and uses the
> network=container:<ID> flag to enter the container's namespace. The
> command health check was trivially fixed by replacing the hardcoded
> `sh -c`.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 
>   src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 
> 
> 
> Diff: https://reviews.apache.org/r/65127/diff/11/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message