mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65728: Add test to check quotes in docker executor health check.
Date Thu, 22 Feb 2018 01:51:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65728/
-----------------------------------------------------------

(Updated Feb. 22, 2018, 1:51 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph
Wu.


Changes
-------

Reabsed + Andy's feedback


Bugs: MESOS-4812 and MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-4812
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

Added `ROOT_DOCKER_DockerHealthyTaskWithQuotedCommand` to make sure that
the docker executor properly deals with quotes in the command health
check to ensure that MESOS-4812 is fixed.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 948bf171dbf3371a11669a641a8f2afe88e3cdab 


Diff: https://reviews.apache.org/r/65728/diff/2/

Changes: https://reviews.apache.org/r/65728/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message