mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65396: Moved docker command check code inside health check library.
Date Thu, 22 Feb 2018 01:45:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65396/
-----------------------------------------------------------

(Updated Feb. 22, 2018, 1:45 a.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.


Changes
-------

Rebased.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

Now with the health check library refactor, the wrapping of `docker
exec` for docker command health checks can be easily moved inside
the library.


Diffs (updated)
-----

  src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f 
  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65396/diff/6/

Changes: https://reviews.apache.org/r/65396/diff/5-6/


Testing
-------

make check


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message