mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 65733: Windows: Fixed flaky Docker command health check test.
Date Wed, 21 Feb 2018 14:19:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65733/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph
Wu.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

The `DockerContainerizerHealthCheckTest.ROOT_DOCKER_
DockerHealthStatusChange` test was flaky on Windows, because
the docker executor manually reaps the container exit code in
case that `docker run` fails to get the exit code. This logic
doesn't work on Windows, since the process might not be visible to
the container host machine, causing `TASK_FAILED` to get sent. By
removing the reaping logic on Windows, the test is much more reliable.


Diffs
-----

  src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc 


Diff: https://reviews.apache.org/r/65733/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message