mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65727: Moved `*DOCKER*` tests to `DockerContainerizerHealthCheckTest`.
Date Wed, 21 Feb 2018 14:16:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65727/#review197851
-----------------------------------------------------------



Diff makes it look worse than it actually is. Basically I moved the `*DOCKER*` tests under
`HealthCheckTest` to go under `DockerContainizerHealthCheckTest`. Then, I moved the "once
per test suite" code in `HealthCheckTest::SetupTestCase()` and `DockerContainerizerTest::SetupTestCase()`
to the "once per test" `DockerContainerizerTest::Setup()` function so that we only pull the
image if we pass the `*DOCKER*` filter. Otherwise, the test suite will fail if Docker isn't
installed since it will fail `SetupTestCase()`.

- Akash Gupta


On Feb. 21, 2018, 2:11 p.m., Akash Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65727/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2018, 2:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman,
and Joseph Wu.
> 
> 
> Bugs: MESOS-8498
>     https://issues.apache.org/jira/browse/MESOS-8498
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In `health_check_tests.cpp`, the `*DOCKER*` tests were moved to
> `DockerContainerizerHealthCheckTest::Setup`, so that pre-pulling only
> happens if the test is actually run. This avoids failing the test suite
> due to the pull failing when docker isn't installed.
> 
> 
> Diffs
> -----
> 
>   src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
> 
> 
> Diff: https://reviews.apache.org/r/65727/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message