mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Review Request 65727: Moved `*DOCKER*` tests to `DockerContainerizerHealthCheckTest`.
Date Wed, 21 Feb 2018 14:11:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65727/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston Kleiman, and Joseph
Wu.


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

In `health_check_tests.cpp`, the `*DOCKER*` tests were moved to
`DockerContainerizerHealthCheckTest::Setup`, so that pre-pulling only
happens if the test is actually run. This avoids failing the test suite
due to the pull failing when docker isn't installed.


Diffs (updated)
-----

  src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 


Diff: https://reviews.apache.org/r/65727/diff/1/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message