-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65469/#review197798
-----------------------------------------------------------
Ship it!
Ship It!
- Jeff Coffler
On Feb. 20, 2018, 7:40 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65469/
> -----------------------------------------------------------
>
> (Updated Feb. 20, 2018, 7:40 p.m.)
>
>
> Review request for mesos, Akash Gupta, Jeff Coffler, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8512
> https://issues.apache.org/jira/browse/MESOS-8512
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The interface of `internal::windows:create_process` was changed to
> accept a `std::array<os::WindowsFD, 3>` instead of a `std::tuple`.
>
> Furthermore, the error handling in `subprocess` was incorrect. We only
> need to check the success of `createChildProcess`; we do not need to
> check if `pid == -1` on Windows. We also now return the actual error
> from `create_process` if it errored, instead of the whole
> `Try<process_data>`.
>
> The TODO about closing the child-ends of the file descriptors was
> resolved. We now close these in `createChildProcess`, immediately after
> `create_process`. This means we only have to do it once.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 785e2e1083d115d25fffde2df74ed8bc1726511c
> 3rdparty/libprocess/src/subprocess_windows.hpp 0183bb451f68528acf31ed97754320c64f35102b
>
>
> Diff: https://reviews.apache.org/r/65469/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
|