mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Akash Gupta <akash-gu...@hotmail.com>
Subject Re: Review Request 65615: Added docker constants and common functions file.
Date Fri, 16 Feb 2018 23:30:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65615/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 11:30 p.m.)


Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston Kleiman.


Changes
-------

Address feedback


Bugs: MESOS-8498
    https://issues.apache.org/jira/browse/MESOS-8498


Repository: mesos


Description
-------

This patch is in preparation of porting docker tests to Windows. There
were a few hardcoded values that were used throughout the codebase,
such as the `alpine` image, that are defined as a constant in a single
file.


Diffs (updated)
-----

  src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 
  src/tests/containerizer/docker_common.hpp PRE-CREATION 
  src/tests/containerizer/docker_containerizer_tests.cpp d1e657050d623ad0412208b3aa3e3101e3654e99

  src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d 
  src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d 


Diff: https://reviews.apache.org/r/65615/diff/2/

Changes: https://reviews.apache.org/r/65615/diff/1-2/


Testing
-------


Thanks,

Akash Gupta


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message