mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 65202: Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.
Date Fri, 16 Feb 2018 18:07:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65202/
-----------------------------------------------------------

(Updated Feb. 16, 2018, 6:07 p.m.)


Review request for mesos, Benjamin Bannier and Gaston Kleiman.


Summary (updated)
-----------------

Adopted `TEST_AWAIT_TIMEOUT` in Mesos tests.


Bugs: MESOS-7016
    https://issues.apache.org/jira/browse/MESOS-7016


Repository: mesos


Description (updated)
-------

Rather than hard-coding a 15sec test timeout, use the libprocess
`TEST_AWAIT_TIMEOUT` variable so that this can be globally tuned.
Added a test flag `--test_await_timeout` that can be used to set
the `TEST_AWAIT_TIMEOUT` on a test run.


Diffs (updated)
-----

  src/tests/agent_container_api_tests.cpp 618569277545205017320aaf1f3a70e540d35e30 
  src/tests/containerizer/cgroups_isolator_tests.cpp 5412a7eccaa836a7f182772f1eb33b10298c96a1

  src/tests/containerizer/xfs_quota_tests.cpp d761ea46fd4f12c6bed74090bf5ead7587f16811 
  src/tests/disk_quota_tests.cpp 31cf4c44b1494afd3501046abffd303c7a1307f8 
  src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 
  src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae 
  src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c 
  src/tests/gc_tests.cpp 947399e9e082070282a48d8aa8f745ba37a64c07 
  src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 
  src/tests/master_contender_detector_tests.cpp 015d310b72a152829641d436f7cb558f72dfd77c 
  src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 
  src/tests/slave_recovery_tests.cpp 898270db9c524fd09599155db4990ae0fa9d2c2f 
  src/tests/slave_tests.cpp d2c242eae3169bff3b77770197a36f171cd668ba 


Diff: https://reviews.apache.org/r/65202/diff/9/

Changes: https://reviews.apache.org/r/65202/diff/8-9/


Testing
-------

make check (Fedora 27).


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message