mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 65640: Fixed leaks and a race condition in `UriDiskProfileTests`.
Date Tue, 13 Feb 2018 23:14:04 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 13, 2018, 11:14 p.m.)

Review request for mesos, Jie Yu and Joseph Wu.

Bugs: MESOS-8567

Repository: mesos


There was a race between `Clock::advance()` in the `FetchFromHTTP` test
and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch
avoids the race by enforcing an order between the dispatch of the
`__poll` function (previously `_poll`) and the clock manipulation
in the test. It also fixed two memory leaks in the test.

Diffs (updated)

  src/ 45f0480be0ccb9d9adf90a8a7468eb2dadc84151 
  src/resource_provider/storage/uri_disk_profile.hpp 22e9d8bee0c82807c8b06ef65751496fcd880acf

  src/resource_provider/storage/uri_disk_profile.cpp 665798fdb085ea34f93bd287fe6f9ab29a265cbf

  src/tests/disk_profile_tests.cpp 1bbbde0d026e8e7388d341746587913926002144 




sudo make check


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message