mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65613: Fixed a bug where MockSlave `id` is not properly initialized.
Date Tue, 13 Feb 2018 06:06:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65613/#review197379
-----------------------------------------------------------


Ship it!




Thanks!

- Benjamin Mahler


On Feb. 12, 2018, 7:32 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65613/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `MockSlave` did not initialize the id field using the input
> argument. Also it is necessary to call its virtual base class
> `ProcessBase` constructor explicitly to avoid argument `id` being
> lost.
> 
> 
> Diffs
> -----
> 
>   src/tests/mock_slave.cpp 597d7abef20dd5f89b16e4616233f02760b9d037 
> 
> 
> Diff: https://reviews.apache.org/r/65613/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message