mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gaston Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 65551: Stopped shutting down the whole default executor on task launch failure.
Date Mon, 12 Feb 2018 23:41:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65551/
-----------------------------------------------------------

(Updated Feb. 12, 2018, 3:41 p.m.)


Review request for mesos, Anand Mazumdar, Greg Mann, Qian Zhang, and Vinod Kone.


Changes
-------

Addressed feedback.

Note: lots of changes to `waited()`.


Bugs: MESOS-8468
    https://issues.apache.org/jira/browse/MESOS-8468


Repository: mesos


Description
-------

The default executor would be completely shutdown on a
`LAUNCH_NESTED_CONTAINER` failure.

This patch makes it kill the affected task group instead of shutting
down and killing all task groups.


Diffs (updated)
-----

  src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea 


Diff: https://reviews.apache.org/r/65551/diff/5/

Changes: https://reviews.apache.org/r/65551/diff/4-5/


Testing
-------

`sudo make check` on GNU/Linux

Regression test on https://reviews.apache.org/r/65552/


Thanks,

Gaston Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message