mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 65545: Start from merge-base when posting reviews.
Date Mon, 12 Feb 2018 13:24:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65545/
-----------------------------------------------------------

(Updated Feb. 12, 2018, 1:24 p.m.)


Review request for mesos, Armand Grillet and Benjamin Bannier.


Repository: mesos


Description (updated)
-------

When posting a review originally created from a branch B, it could
happen that the resulting review included garbage changes if B was
updated between revisions. (i.e., pulling new master changes)

This review changes the logic of the post-reviews.py script to only
include the changes between HEAD and the merge base of the tracking
branch into the review.


Diffs (updated)
-----

  support/post-reviews.py 231a3ac641d1ddf2f1788829f4fa8c36811bed90 


Diff: https://reviews.apache.org/r/65545/diff/3/

Changes: https://reviews.apache.org/r/65545/diff/2-3/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message