mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 65545: Start from merge-base when posting reviews.
Date Sat, 10 Feb 2018 02:42:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65545/#review197220
-----------------------------------------------------------



Patch looks great!

Reviews applied: [65545]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 7, 2018, 3:22 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65545/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Armand Grillet and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When posting a review originally created from a branch B, it could happen that the resulting
review included garbage changes if B was updated between revisions. (i.e., pulling new master
changes)
> 
> This review changes the logic of the `post-reviews.py` script to only include the changes
between `HEAD` and the merge base of the tracking branch into the review.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 94b43253f25044a79009010e92363d1536c74299 
> 
> 
> Diff: https://reviews.apache.org/r/65545/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message