mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Review Request 65585: Improved new CLI bootstrap script, now runnable from anywhere.
Date Fri, 09 Feb 2018 14:54:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65585/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Kevin Klues.


Bugs: MESOS-8240
    https://issues.apache.org/jira/browse/MESOS-8240


Repository: mesos


Description
-------

We can now call `src/python/cli_new/bootstrap` from anywhere and a
virtual environement will be created in the current directory.
>From here, the CLI and its tests can be run.

No files or directories are created in the `src/` directory when
the bootstrap script is called anymore, except if the script is
run from `src/`. This is useful to build the CLI as part of Mesos,
a process that should not modify the source directory.


Diffs
-----

  src/python/cli_new/README.md 847141db9a1f9eb5c78b2d50367b599a5c72ce61 
  src/python/cli_new/activate 65df76f4590caf8160435ccbc1d6b199b115f7f8 
  src/python/cli_new/bin/mesos c5152a2ebf8704c804bb4f39e46580a512aecdea 
  src/python/cli_new/bin/mesos-cli-tests 07659e0b4551c2381828b256608d2c6ced3ae745 
  src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a 
  src/python/cli_new/deactivate 3dbe16765cad6f10523b1a3824608005e81b0944 


Diff: https://reviews.apache.org/r/65585/diff/1/


Testing
-------

On Fedora 25:
```
apache-mesos (MESOS-8240)$ cd src/python/cli_new/
cli_new (MESOS-8240)$ ./bootstrap
cli_new (MESOS-8240)$ source .virtualenv/activate
(mesos-cli) cli_new (MESOS-8240)$ mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos <command> [<args>...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  task    Interacts with the tasks running in a Mesos cluster

See 'mesos help <command>' for more information on a specific command.
(mesos-cli) cli_new (MESOS-8240)$ source .virtualenv/deactivate
cli_new (MESOS-8240)$ rm -rf .virtualenv/
cli_new (MESOS-8240)$ cd ..
python (MESOS-8240)$ ./cli_new/bootstrap
python (MESOS-8240)$ source .virtualenv/activate
(mesos-cli) python (MESOS-8240)$ mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos <command> [<args>...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  task    Interacts with the tasks running in a Mesos cluster

See 'mesos help <command>' for more information on a specific command.
```


Thanks,

Armand Grillet


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message