mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 65467: Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.
Date Thu, 08 Feb 2018 19:49:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65467/
-----------------------------------------------------------

(Updated Feb. 8, 2018, 11:49 a.m.)


Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.


Changes
-------

Make it `set(bool)` so it can be used to turn things on and off.


Summary (updated)
-----------------

Windows: Added `internal::windows::set_inherit(WindowsFD, bool)`.


Bugs: MESOS-8512
    https://issues.apache.org/jira/browse/MESOS-8512


Repository: mesos


Description (updated)
-------

This function is used on Windows to explicitly enable or disable
inheritance on a handle.


Diffs (updated)
-----

  3rdparty/stout/include/stout/internal/windows/inherit.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/65467/diff/2/

Changes: https://reviews.apache.org/r/65467/diff/1-2/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message