-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65571/#review197095
-----------------------------------------------------------
PASS: Mesos patch 65571 was successfully built and tested.
Reviews applied: `['65571']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65571
- Mesos Reviewbot Windows
On Feb. 8, 2018, 4:50 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65571/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 4:50 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Vinod Kone.
>
>
> Bugs: MESOS-8550
> https://issues.apache.org/jira/browse/MESOS-8550
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The function `MasterDetector::detect()` returns a value of type
> `Future<Option<MasterInfo>>`, which, according to its documentation,
> can be `None` if an election occured and no master is elected.
>
> However, the code in `Master::detected()` was only handling the
> cases of a failed future or a valid `MasterInfo` object.
>
>
> Diffs
> -----
>
> src/master/master.cpp cc2685a6bc14103c639ce776cf1c912361e93381
> src/tests/cluster.hpp ad2b80e658d2f8afcefe9969d62cd33f0c475ce9
> src/tests/master_tests.cpp 7112bb4efcc312dc4f68bdc44fb685c7624002b1
>
>
> Diff: https://reviews.apache.org/r/65571/diff/1/
>
>
> Testing
> -------
>
> `./mesos-tests`
>
>
> Thanks,
>
> Benno Evers
>
>
|