mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65558: Added helpers for supporting profile selectors.
Date Thu, 08 Feb 2018 04:37:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65558/
-----------------------------------------------------------

(Updated Feb. 8, 2018, 4:37 a.m.)


Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.


Bugs: MESOS-8510
    https://issues.apache.org/jira/browse/MESOS-8510


Repository: mesos


Description
-------

This patches validates that a profile's manifest must have a selector
and adds a helper function for selecting resource providers.


Diffs (updated)
-----

  src/resource_provider/storage/disk_profile_utils.hpp fa2c7ec5055577b12e5e795064bf848b9a887def

  src/resource_provider/storage/disk_profile_utils.cpp c84b6e18665086968808fb5cb0a313c1050ea587



Diff: https://reviews.apache.org/r/65558/diff/2/

Changes: https://reviews.apache.org/r/65558/diff/1-2/


Testing
-------

Tests done later in chain.

NOTE: The next patch in chain only include necessary changes for the validation tests. Tests
for the helper function will be added in a separated patch.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message