mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 65496: Fixed a bug relating to lingering executors [2/2].
Date Thu, 08 Feb 2018 01:55:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65496/#review197067
-----------------------------------------------------------


Ship it!




This description doesn't seem to capture the cause of the issue here? Mentioning something
about the everSentTask check occurs before we've removed the dropped tasks would be helpful
for posterity.

- Benjamin Mahler


On Feb. 6, 2018, 5:42 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65496/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2018, 5:42 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8411
>     https://issues.apache.org/jira/browse/MESOS-8411
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A task-less v1 executor could linger if the agent fails before
> any of the executor's initial tasks got delivered.
> 
> This patch fixes this issue by checking if an executor is
> task-less during the executor `subscribe()` and shutdown
> the executor accordingly.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp a6a5c93ab2d541c870cb52587495de20ed5ac1f4 
> 
> 
> Diff: https://reviews.apache.org/r/65496/diff/2/
> 
> 
> Testing
> -------
> 
> make check.
> Dedicated test #65497
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message