mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@mesosphere.io>
Subject Re: Review Request 65499: Fixed the flakiness of the ROOT_ConvertPreExistingVolume test.
Date Thu, 08 Feb 2018 00:00:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65499/
-----------------------------------------------------------

(Updated Feb. 8, 2018, midnight)


Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jie Yu.


Changes
-------

Rebased.


Bugs: MESOS-8474
    https://issues.apache.org/jira/browse/MESOS-8474


Repository: mesos


Description
-------

This unit test is flaky because the master might send out an offer
before both offer operations of a previous `ACCEPT` call are finished.
This is fixed by manipulating the clock such that no offer won't be
sent out until the master receives status updates for both operations.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp ce241617ee555e5a67e552dd30b0e7afee161386



Diff: https://reviews.apache.org/r/65499/diff/2/

Changes: https://reviews.apache.org/r/65499/diff/1-2/


Testing
-------

sudo make check
Ran in repetition.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message